On Tue, Jun 06, 2017 at 08:52:29AM +0300, Leon Romanovsky wrote:
> On Mon, Jun 05, 2017 at 11:20:58AM -0600, Jason Gunthorpe wrote:
> > On Wed, May 10, 2017 at 02:25:23PM +0300, ahmad omary wrote:
> >
> > > struct ibv_dm *ibv_alloc_dm(struct ibv_context *context,
> > > struct ibv_alloc_dm_attr *dm_attr);
> > >
> > > struct ibv_alloc_dm_attr{
> > > size_t length;
> > > uint32_t comp_mask; /*enable future extensions*/
> > > }
> >
> > Can we please stop this madness where every function call needs to
> > accept a struct?
> >
> > It is perfectly fine to add new function calls if new arguments are
> > needed someday.
>
> IMHO, generally speaking, it is better and cleaner to have similar functions
> signatures for all APIs which is exported to user.
>
> >
> > > int ibv_memcpy_dm(struct ibv_dm *dm, struct ibv_memcpy_dm_attr *
> > > memcpy_dm_attr);
> >
> > To be clear, this is has to be a sycall, right?
>
> Yes
Or to be more clear, it depends on the memory type exposed and specific vendor
implementation (memcpy, e.t.c.).
Thanks
>
> >
> > Jason
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
