Re: [PATCH] IB/bnxt_re: Check return value from get_link_ksettings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yuval,

[auto build test WARNING on rdma/master]
[also build test WARNING on v4.12-rc4 next-20170605]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yuval-Shaia/IB-bnxt_re-Check-return-value-from-get_link_ksettings/20170605-182417
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/bnxt_re/ib_verbs.c: In function '__to_ib_speed_width':
>> drivers/infiniband/hw/bnxt_re/ib_verbs.c:189:10: warning: missing braces around initializer [-Wmissing-braces]
      struct ethtool_link_ksettings lksettings = {0};
             ^
   drivers/infiniband/hw/bnxt_re/ib_verbs.c:189:10: warning: (near initialization for 'lksettings.base') [-Wmissing-braces]

vim +189 drivers/infiniband/hw/bnxt_re/ib_verbs.c

   173			/* GUID should be made as READ-ONLY */
   174			break;
   175		case IB_DEVICE_MODIFY_NODE_DESC:
   176			/* Node Desc should be made as READ-ONLY */
   177			break;
   178		default:
   179			break;
   180		}
   181		return 0;
   182	}
   183	
   184	static void __to_ib_speed_width(struct net_device *netdev, u8 *speed, u8 *width)
   185	{
   186		u32 espeed = SPEED_UNKNOWN;
   187	
   188		if (netdev->ethtool_ops && netdev->ethtool_ops->get_link_ksettings) {
 > 189			struct ethtool_link_ksettings lksettings = {0};
   190			int rc;
   191	
   192			rtnl_lock();
   193			rc = netdev->ethtool_ops->get_link_ksettings(netdev,
   194								     &lksettings);
   195			rtnl_unlock();
   196	
   197			if (!rc)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux