On Thu, Jun 01, 2017 at 09:24:34AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> There is no need to return always zero for function which is not
> supported. The IB stack treats uninitialized ib_device->functions as
> not implemented.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/bnxt_re/ib_verbs.c | 17 -----------------
> drivers/infiniband/hw/bnxt_re/ib_verbs.h | 3 ---
> drivers/infiniband/hw/bnxt_re/main.c | 1 -
> 3 files changed, 21 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> index 7ba9e699d7ab..c2a12b8fe8fb 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c
> @@ -271,23 +271,6 @@ int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
> return 0;
> }
>
> -int bnxt_re_modify_port(struct ib_device *ibdev, u8 port_num,
> - int port_modify_mask,
> - struct ib_port_modify *port_modify)
> -{
> - switch (port_modify_mask) {
> - case IB_PORT_SHUTDOWN:
> - break;
> - case IB_PORT_INIT_TYPE:
> - break;
> - case IB_PORT_RESET_QKEY_CNTR:
> - break;
> - default:
> - break;
> - }
> - return 0;
> -}
> -
> int bnxt_re_get_port_immutable(struct ib_device *ibdev, u8 port_num,
> struct ib_port_immutable *immutable)
> {
> diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.h b/drivers/infiniband/hw/bnxt_re/ib_verbs.h
> index 5c3d71765454..4e8d9010f112 100644
> --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.h
> +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.h
> @@ -129,9 +129,6 @@ int bnxt_re_modify_device(struct ib_device *ibdev,
> struct ib_device_modify *device_modify);
> int bnxt_re_query_port(struct ib_device *ibdev, u8 port_num,
> struct ib_port_attr *port_attr);
> -int bnxt_re_modify_port(struct ib_device *ibdev, u8 port_num,
> - int port_modify_mask,
> - struct ib_port_modify *port_modify);
> int bnxt_re_get_port_immutable(struct ib_device *ibdev, u8 port_num,
> struct ib_port_immutable *immutable);
> int bnxt_re_query_pkey(struct ib_device *ibdev, u8 port_num,
> diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c
> index 5d355401179b..6951f4b688d1 100644
> --- a/drivers/infiniband/hw/bnxt_re/main.c
> +++ b/drivers/infiniband/hw/bnxt_re/main.c
> @@ -473,7 +473,6 @@ static int bnxt_re_register_ib(struct bnxt_re_dev *rdev)
> ibdev->modify_device = bnxt_re_modify_device;
>
> ibdev->query_port = bnxt_re_query_port;
> - ibdev->modify_port = bnxt_re_modify_port;
> ibdev->get_port_immutable = bnxt_re_get_port_immutable;
> ibdev->query_pkey = bnxt_re_query_pkey;
> ibdev->query_gid = bnxt_re_query_gid;
> --
> 2.12.2
Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
