On Sun, Jun 04, 2017 at 08:26:30PM +0300, Leon Romanovsky wrote: > On Sun, Jun 04, 2017 at 08:06:19PM +0300, Yuval Shaia wrote: > > The functions get_link_ksettings and get_settings might return bad > > status indicating a failure to retrieve interface atttibutes. > > Check return value to cover this case. > > > > Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > > --- > > drivers/infiniband/sw/rxe/rxe_verbs.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > Thanks, > Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> Thanks Leon for your review. I'm about to post another version for this patch and will appreciate your review. Looks like call to get_link_ksettings should be protected by rtnl lock, it is undocumented but for example __ethtool_get_link_ksettings prints an ugly dump_stack when this happen. I will do the same as what is done in function __to_ib_speed_width -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
