On Sun, May 14, 2017 at 01:32:06PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
>
> ipoib_dev_uninit_default() call is used in ipoib_main.c file only
> and it generates the following warning from smatch tool:
> drivers/infiniband/ulp/ipoib/ipoib_main.c:1593:6: warning:
> symbol 'ipoib_dev_uninit_default' was not declared. Should it
> be static?
>
> so let's declare that function as static.
>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 2869d1adb1de..a115c0b7a310 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1590,7 +1590,7 @@ static void ipoib_neigh_hash_uninit(struct net_device *dev)
> wait_for_completion(&priv->ntbl.deleted);
> }
>
> -void ipoib_dev_uninit_default(struct net_device *dev)
> +static void ipoib_dev_uninit_default(struct net_device *dev)
> {
> struct ipoib_dev_priv *priv = ipoib_priv(dev);
>
Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> --
> 2.12.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
