On Thu, May 04, 2017 at 01:21:15PM +0000, Boyer, Andrew wrote:
>
> On 5/4/17, 8:36 AM, "linux-rdma-owner@xxxxxxxxxxxxxxx on behalf of Leon
> Romanovsky" <linux-rdma-owner@xxxxxxxxxxxxxxx on behalf of
> leon@xxxxxxxxxx> wrote:
>
> >From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> >Callers of rxe_mem_copy() provide pointer to store updated CRC
> >value. That pointer was supposed to be updated, but the
> >commit cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> >mistakenly removed that assignment for RXE_MEM_TYPE_DMA memory type.
> >
> >The code worked because there are no actual callers with
> >RXE_MEM_TYPE_DMA, who are interested in returned value of crcp.
> >The one caller in read_reply(), who uses the returned crcp didn't
> >set RXE_MEM_TYPE_DMA as mem->type.
> >
> >Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
> >Reported-by: Andrew Boyer <andrew.boyer@xxxxxxxx>
> >Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >Acked-by: Moni Shoua <monis@xxxxxxxxxxxx>
> >---
> >Hi Doug,
> >
> >It will be great if you forward this patch as part of your second pull
> >request.
> >As you can see from the commit message, it fixes issue spotted by Andrew.
> >
> >Thanks
> >---
> > drivers/infiniband/sw/rxe/rxe_mr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Andrew Boyer <andrew.boyer@xxxxxxxx>
Thank you for catching, reviewing and testing it.
Attachment:
signature.asc
Description: PGP signature
