On Thu, Apr 27, 2017 at 12:14:20PM +0300, Dan Carpenter wrote:
> We need to call spin_unlock_irqrestore() instead of vanilla
> spin_unlock() on this error path.
>
> Fixes: 119a8e708d16 ("IB/rdmavt: Add AH to rdmavt")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/infiniband/sw/rdmavt/ah.c b/drivers/infiniband/sw/rdmavt/ah.c
> index 16c446142c2a..b0f09fb45c72 100644
> --- a/drivers/infiniband/sw/rdmavt/ah.c
> +++ b/drivers/infiniband/sw/rdmavt/ah.c
> @@ -119,7 +119,7 @@ struct ib_ah *rvt_create_ah(struct ib_pd *pd,
>
> spin_lock_irqsave(&dev->n_ahs_lock, flags);
> if (dev->n_ahs_allocated == dev->dparms.props.max_ah) {
> - spin_unlock(&dev->n_ahs_lock);
> + spin_unlock_irqrestore(&dev->n_ahs_lock, flags);
> kfree(ah);
> return ERR_PTR(-ENOMEM);
> }
Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
