On Tue, Apr 25, 2017 at 04:37:35PM -0400, Laurence Oberman wrote:
>
>
> ----- Original Message -----
> > From: "Leon Romanovsky" <leonro@xxxxxxxxxxxx>
> > To: "Bart Van Assche" <bart.vanassche@xxxxxxxxxxx>
> > Cc: "Doug Ledford" <dledford@xxxxxxxxxx>, "Max Gurtovoy" <maxg@xxxxxxxxxxxx>, "Sagi Grimberg" <sagi@xxxxxxxxxxx>,
> > "Israel Rukshin" <israelr@xxxxxxxxxxxx>, "Laurence Oberman" <loberman@xxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx
> > Sent: Tuesday, April 25, 2017 1:58:49 PM
> > Subject: Re: [PATCH, untested] mlx5: Avoid that mlx5_ib_sg_to_klms() overflows the klms[] array
> >
> > On Mon, Apr 24, 2017 at 03:15:28PM -0700, Bart Van Assche wrote:
> > > ib_map_mr_sg() can pass an SG-list to .map_mr_sg() that is larger
> > > than what fits into a single MR. .map_mr_sg() must not attempt to
> > > map more SG-list elements than what fits into a single MR.
> > > Hence make sure that mlx5_ib_sg_to_klms() does not write outside
> > > the MR klms[] array.
> > >
> > > Fixes: b005d3164713 ("mlx5: Add arbitrary sg list support")
> > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> > > Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>
> > > Cc: Sagi Grimberg <sagi@xxxxxxxxxxx>
> > > Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> > > Cc: Israel Rukshin <israelr@xxxxxxxxxxxx>
> > > Cc: <stable@xxxxxxxxxxxxxxx>
> > > ---
> > > drivers/infiniband/hw/mlx5/mr.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> > Bart,
> >
> > Thanks a lot, it indeed looks right.
> > Acked-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> > Thanks
> >
>
>
> Hello Bart, Leon, Max and Israel.
>
> I cloned off Barts tree.
>
> git clone https://github.com/bvanassche/linux
> cd linux
> git checkout block-scsi-for-next
>
> I checked all patches were in for this test.
>
> a83e404 IB/srp: Reenable IB_MR_TYPE_SG_GAPS
> dfa5a2b mlx5: Avoid that mlx5_ib_sg_to_klms() overflows the klms[] array
> f759c80 mlx5: Fix mlx5_ib_map_mr_sg mr lengt
>
> Built and tested the kernel.
>
> However this issue is not resolved :(
>
> [ 2707.931909] scsi host1: ib_srp: failed RECV status WR flushed (5) for CQE ffff8817edca86b0
> [ 2708.089806] mlx5_0:dump_cqe:262:(pid 20129): dump error cqe
> [ 2708.121342] 00000000 00000000 00000000 00000000
> [ 2708.147104] 00000000 00000000 00000000 00000000
> [ 2708.172633] 00000000 00000000 00000000 00000000
> [ 2708.198702] 00000000 0f007806 2500002a 14a527d0
Parsed version:
hw_error_syndrome : 0xf
hw_syndrome_type : 0x0
vendor_error_syndrome : 0x78
syndrome : MEMORY_WINDOW_BIND_ERROR (0x6)
s_wqe_opcode : UMR (0x25)
opcode : REQUESTOR_ERROR (0xd)
cqe_format : NO_INLINE_DATA (0x0)
owner : 0x0
Description:
umr.klm_octoword_count > mkey.mtt_octoword_count
Sagi, Max,
Any idea where can it be?
Thanks
Attachment:
signature.asc
Description: PGP signature
