On 04/25/2017 01:49 AM, Honggang LI wrote:
> From: Honggang Li <honli@xxxxxxxxxx>
>
> ARM chars are unsigned by default. getopt_long return 255 instead -1.
> That will cause an endless loop for aarch64 platform.
>
> Signed-off-by: Honggang Li <honli@xxxxxxxxxx>
> ---
> rdma-ndd/rdma-ndd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rdma-ndd/rdma-ndd.c b/rdma-ndd/rdma-ndd.c
> index 1579a02..e7be22b 100644
> --- a/rdma-ndd/rdma-ndd.c
> +++ b/rdma-ndd/rdma-ndd.c
> @@ -297,7 +297,7 @@ int main(int argc, char *argv[])
> { }
> };
>
> - char c = getopt_long(argc, argv, "fh", long_opts, &opt_idx);
> + int c = getopt_long(argc, argv, "fh", long_opts, &opt_idx);
> if (c == -1)
> break;
>
>
int is the return type of the function signature anyway so this was
wrong from the start.
https://linux.die.net/man/3/getopt_long
Acked-by: Jonathan Toppins <jtoppins@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
