Re: [PATCH 02/20] IB/hfi1: Remove hyper-thread siblings by walking CPU mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 20, 2017 at 08:34:20PM +0300, Leon Romanovsky wrote:
> On Thu, Apr 20, 2017 at 05:20:18PM +0000, Sanchez, Sebastian wrote:
> > The irq layer PCI_IRQ_AFFINITY flag makes pci_alloc_irq_vectors() spread all the interrupts around the available CPUs, however, the API doesn't allow to exclude the hyper threading CPU cores or limit the CPUs to use for the affinity mask. If the API had a way to provide an affinity hint into this function instead of having them automatically generated it provide more flexibility to the hfi1 driver.
> 
> It is open source, add it if you need it.

Exactly.  And it's not like hfi1 is a super special beast. IFF the
hyperthread magic makes sense it will be useful for other device aswell.

So I'd like to repeat my NAK for "improving" any irq affinity magic
in drivers.  Move to the common code and improve it as needed instead of
making the mess worse.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux