> > This patch addresses that drawback by defining three address handle > > types namely 'ib', 'eth' and 'opa'. While these these types share > most > > of the original fields, the changes provide the infrastucture to > > extend and cleanup the fields based on their types. > > So UR doing a massive renaming but the current series doesn't make any > real use in that, right? I think it would be much better to see the > actual new functionality before applying this renaming exercise The actual new functionality is adding support for opa addressing. IMO, even without adding OPA support, the cleanup of AH attributes is worthwhile. The rename from ib_ah_attr -> rdma_ah_attr occurs because rdma_ah_attr is a union of a new ib_ah_attr structure + eth_ah_attr. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f