> +static inline nvme_rdma_queue_sig_limit(struct nvme_rdma_queue *queue) > +{ > + int sig_limit; > + > + /* We signal completion every queue depth/2 and also > + * handle the case of possible device with queue_depth=1, > + * where we would need to signal every message. > + */ > + sig_limit = max(queue->queue_size / 2, 1); > + return (++queue->sig_count % sig_limit) == 0; > +} I would love if we could do this at the ib_qp level. I also know you found a real bug and we want it fixed ASAP, so maybe for now we should merge this one: Reviewed-by: Christoph Hellwig <hch@xxxxxx> and then do the generic version. Marta, do you want to tackle the generic version or should I look into this once I get a little time. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html