On Wed, Apr 5, 2017 at 7:10 PM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Mar 30, 2017 at 09:54:52PM +0300, Matan Barak wrote: >> > /* Convert a locked reference obtained from rdma_lookup_get_uobject to >> > a simple kref by dropping the read/write lock. The caller must pair >> > this with uverbs_uobject_put */ >> > void rdma_lookup_to_kref(struct ib_uobject *uobj, bool write); >> > >> > Similarly I think you should add a uobj_remove_commit_kref() wrapper >> > which does remove_commit but leaves the caller with a kref, as that >> > pattern seems to come up alot in this code as well. >> > >> >> Actually, this isn't that frequent pattern. It mainly happens in >> ib_uverbs_lookup_comp_file. There's a different pattern of inc_kref >> and then remove_commit which is used in order to copy the latest >> events_reported info before releasing the uobject's memory. > > That is the one I was talking about.. > >> When this destroy function comes from the user-space, the pd object >> is locked, so this test would be atomic and safe. The uobject won't >> be destroyed, until the object itself is destroyed. So effectively, >> it's like taking another kref :) > > And this is the sketchyness I don't like - this is something that > would be easy to break and you have to rely on quite a few assumptions > to know that this is 'safe'. > > It would be much better to hold the kref - that should be cleaned up > before start messing with this much more. > Effectively this kref is used to capture the dependencies between various objects. Obviously, It should be part of the verbs layer (and not part of the uverbs layer). It relies on the caller's code to provide atomic behavior, meaning - a ULP (or uverbs) should guarantee destroy_x isn't called while using x as a dependency of a new object. This won't solve the "inc_uobject_kref; destroy_uobject" schema, as in this case we really want to destroy the object, but we want to keep the uobject alive in order to get information about the object's state at destruction. If we use kref on the uobject only, we lose the kref count in ULPs. Moreover, we'll need to somehow return the information about the destruction state from the destroy call (instead of writing it to the uobject). This is because uobject's kref == 0 will be the only case leading for object destruction and memory deallocation. This is pretty big change. It could be done later if we want (I'm not sure the current approach of object and uobject having different lifetime isn't better) and not as part of the ABI changes :) > Jason Matan -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
