On Wed, Apr 05, 2017 at 09:50:59PM -0400, Dennis Dalessandro wrote: > On 04/04/2017 03:17 PM, Leon Romanovsky wrote: > > Hi Doug, > > > > This patchset mostly comes from Erez with one exception in the first patch. > > > > That patch origins from two different commits, first from Niranjana who added > > RDMA netdev interface and second from Erez who added IPoIB support. > > > > During the preparation to submission, I squashed their commits into one > > and refactored code to allow submission as a standalone topic without creating > > dependecies between different submissions. This caused to change in author line. > > I hope that it doesn't really matter and it won't stop you from merging it. > > I think that it does indeed matter. The patch was authored by Niranjana it > should reflect as such. Why not take Niranjana's patch(s), the fact that you > folded them in seems to mean you at least agree with the patch. Sure, I agree, but I was supposed to remove all VNIC code from that patch, which is unrelated to IPoIB. If Niranjana feels comfortable to be authored on IPoIB code, the following code will do the trick. git commit --amend --author "Niranjana Vishwanathapura <niranjana.vishwanathapura@xxxxxxxxx>" Thanks > > -Denny
Attachment:
signature.asc
Description: PGP signature
