> > @@ -3142,7 +2583,7 @@ ssize_t ib_uverbs_attach_mcast(struct > > ib_uverbs_file *file, > > if (copy_from_user(&cmd, buf, sizeof cmd)) > > return -EFAULT; > > > > - qp = idr_write_qp(cmd.qp_handle, file->ucontext); > > + qp = uobj_get_obj_read(qp, cmd.qp_handle, file->ucontext); > > This converts an idr_write to get_obj_read... > > > if (!qp) > > return -EINVAL; > > > > @@ -3171,7 +2612,7 @@ ssize_t ib_uverbs_attach_mcast(struct > > ib_uverbs_file *file, > > kfree(mcast); > > > > out_put: > > - put_qp_write(qp); > > + uobj_put_obj_read(qp); > > > > return ret ? ret : in_len; > > } > > @@ -3190,16 +2631,16 @@ ssize_t ib_uverbs_detach_mcast(struct > > ib_uverbs_file *file, > > if (copy_from_user(&cmd, buf, sizeof cmd)) > > return -EFAULT; > > > > - qp = idr_write_qp(cmd.qp_handle, file->ucontext); > > + qp = uobj_get_obj_read(qp, cmd.qp_handle, file->ucontext); > > Same here. Are these changes correct? I think your next patch addresses this comment. :) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
