Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> On Wed, Apr 5, 2017 at 11:53 AM, Leon Romanovsky <leon@xxxxxxxxxx> wrote: > > From: Artemy Kovalyov <artemyko@xxxxxxxxxxxx> > > Size of pages are held by struct ib_umem in page_size field. > > It is better to store it as an exponent, because page size by nature > is always power-of-two and used as a factor, divisor or ilog2's argument. > > The conversion of page_size to be page_shift allows to have portable > code and avoid following error while compiling on ARM: > > ERROR: "__aeabi_uldivmod" [drivers/infiniband/core/ib_core.ko] undefined! > > CC: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> > CC: Steve Wise <swise@xxxxxxxxxxx> > CC: Lijun Ou <oulijun@xxxxxxxxxx> > CC: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > CC: Adit Ranadive <aditr@xxxxxxxxxx> > CC: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx> > CC: Ram Amrani <Ram.Amrani@xxxxxxxxxx> > Signed-off-by: Artemy Kovalyov <artemyko@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx> > --- > Change from v0: > * Remove temp variable (pg_shift) variable from i40iw driver. > --- > drivers/infiniband/core/umem.c | 15 ++++++--------- > drivers/infiniband/core/umem_odp.c | 12 ++++++------ > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 12 ++++++------ > drivers/infiniband/hw/cxgb3/iwch_provider.c | 4 ++-- > drivers/infiniband/hw/cxgb4/mem.c | 4 ++-- > drivers/infiniband/hw/hns/hns_roce_cq.c | 3 +-- > drivers/infiniband/hw/hns/hns_roce_mr.c | 9 +++++---- > drivers/infiniband/hw/hns/hns_roce_qp.c | 3 +-- > drivers/infiniband/hw/i40iw/i40iw_verbs.c | 10 +++++----- > drivers/infiniband/hw/mlx4/cq.c | 2 +- > drivers/infiniband/hw/mlx4/mr.c | 6 +++--- > drivers/infiniband/hw/mlx4/qp.c | 2 +- > drivers/infiniband/hw/mlx4/srq.c | 2 +- > drivers/infiniband/hw/mlx5/mem.c | 4 ++-- > drivers/infiniband/hw/mlx5/odp.c | 2 +- > drivers/infiniband/hw/mthca/mthca_provider.c | 5 ++--- > drivers/infiniband/hw/nes/nes_verbs.c | 4 ++-- > drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 15 ++++++--------- > drivers/infiniband/hw/qedr/verbs.c | 8 ++++---- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_misc.c | 2 +- > drivers/infiniband/sw/rdmavt/mr.c | 8 ++++---- > drivers/infiniband/sw/rxe/rxe_mr.c | 8 +++----- > include/rdma/ib_umem.h | 4 ++-- > 23 files changed, 67 insertions(+), 77 deletions(-) For the changes in both ocrdma and bnxt_re modules - Acked-by: Selvin Xavier <selvin.xavier@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
