Re: [PATCH rdma-next 6/6] IB/IPoIB: Support acceleration options callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 04, 2017 at 01:42:34PM -0600, Jason Gunthorpe wrote:
> On Tue, Apr 04, 2017 at 10:17:32PM +0300, Leon Romanovsky wrote:
> > -/* Keep the refactoring compile able */
> > -#define ipoib_priv netdev_priv
> > +static inline void *ipoib_priv(const struct net_device *dev)
> > +{
> > +	struct rdma_netdev *rn = netdev_priv(dev);
> > +
> > +	return rn->clnt_priv;
> > +}
>
> This should return struct ipoib_dev_priv *

You are right, this is the whole purpose of ipoib_priv().

>
> >  static ssize_t show_pkey(struct device *dev,
> >  			 struct device_attribute *attr, char *buf)
> >  {
> > -	struct ipoib_dev_priv *priv = netdev_priv(to_net_dev(dev));
> > +	struct ipoib_dev_priv *priv = ipoib_priv(to_net_dev(dev));
>
> Several of these seem to be in the wrong patch
>
> Jason

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux