On Wed, Mar 29, 2017 at 01:20:20PM +0300, Shamir Rabinovitch wrote: > On Tue, Mar 28, 2017 at 08:05:06PM +0300, Leon Romanovsky wrote: > > > > Thank you for checking it. > > > > There is one more thing which I noticed, you should check the return > > values of debugfs_remove and destroy debugfs in case of failures. > > > > Hi Leon, > > 'debugfs_remove' prototype is "static inline void > debugfs_remove(struct dentry *dentry)". > If you typed the wrong function please let me know. Sorry, it was my fault, I mistyped and intended to write debugfs_rename which you used in previous version of your patch. linux-rdma git:(master) git grep debugfs_rename .... fs/debugfs/inode.c: * debugfs_rename - rename a file/directory in the debugfs filesystem fs/debugfs/inode.c:struct dentry *debugfs_rename(struct dentry *old_dir, struct dentry *old_dentry, fs/debugfs/inode.c:EXPORT_SYMBOL_GPL(debugfs_rename); .... > > BR, Shamir >
Attachment:
signature.asc
Description: PGP signature
