On Sat, Mar 25, 2017 at 10:13:26AM +0300, Leon Romanovsky wrote: > On Fri, Mar 24, 2017 at 12:09:14PM -0600, Jason Gunthorpe wrote: > > On Fri, Mar 24, 2017 at 04:49:05PM +0300, Leon Romanovsky wrote: > > > On Thu, Mar 23, 2017 at 02:02:14PM -0600, Jason Gunthorpe wrote: > > > > On Thu, Mar 23, 2017 at 09:11:55PM +0200, Leon Romanovsky wrote: > > > > > > > index 3defc05..f47fcec 100644 > > > > > > > +++ b/debian/changelog > > > > > > > @@ -1,5 +1,8 @@ > > > > > > > -rdma-core (13-1) unstable; urgency=low > > > > > > > +rdma-core (14-1) unstable; urgency=low > > > > > > > + > > > > > > > + * Bump version. > > > > > > > > > > > > I haven't been adding new change log entires in the past, this is just > > > > > > a standin file - Debian will maintain their own in their .diff. Same > > > > > > with rpm. > > > > > > > > > > It was more convenient for me to bump version in this file too, > > > > > so new symbols in debian/*.symbol will have more clear minimal > > > > > version (14-1), which is close to rdma-core-14. > > > > > > > > I meant, you still have to bump the version, I was just doing it in > > > > place, because we are not actually keeping a changelog. > > > > > > And what about 13-1 in all *.symbols files? It will need to be changed > > > too. > > > > Do you need a changelog entry to have stuff in the symbols file? > > I think that we need corresponding version in changelog. > > If we change version to be 14-1, so all previous declarations in > ibverbs-providers.symbols will need to be updated, because version 13-1 > won't exist anymore. > > ➜ rdma-core git:(master) cat debian/ibverbs-providers.symbols > libmlx5.so.1 ibverbs-providers #MINVER# > MLX5_1.0@MLX5_1.0 13-1 > mlx5dv_init_obj@MLX5_1.0 13-1 > mlx5dv_query_device@MLX5_1.0 13-1 > > > > > BTW, there are bad looking things in travis with this PR: > > > > parsechangelog/debian: warning: debian/changelog(l5): found start of entry where expected more change data or trailer > > LINE: rdma-core (13-1) unstable; urgency=low > > parsechangelog/debian: warning: debian/changelog(l5): found eof > > where expected more change data or trailer > > > > libmlx5.so.1 ibverbs-providers #MINVER# > > MLX5_1.0@MLX5_1.0 13-1 > > MLX5_1.14@MLX5_1.14 14-1 > > + MLX5_1.1@MLX5_1.1 14-1 > > + mlx5dv_create_cq@MLX5_1.1 14-1 > > > > Etc.. > > It is actual error, strange that travis passed while it was supposed to fail. > > The commit https://github.com/linux-rdma/rdma-core/pull/103/commits/4ba27e66294f59db7c969bde1580e7aa8d718cd7 > added MLX5_1.1, but in commit https://github.com/linux-rdma/rdma-core/pull/103/commits/9614ecdae2a6a5448cab819a057c703a570b3686 > debian was updated with incorrect stanza (MLX5_1.14). https://github.com/linux-rdma/rdma-core/pull/107 > > > > > https://travis-ci.org/linux-rdma/rdma-core/builds/214329236 > > > > > Jason
Attachment:
signature.asc
Description: PGP signature
