On Tue, Mar 21, 2017 at 01:49:55PM +0200, Leon Romanovsky wrote: > On Mon, Mar 20, 2017 at 02:59:27PM -0600, Jason Gunthorpe wrote: > > On Mon, Mar 20, 2017 at 09:08:22PM +0200, Erez Shitrit wrote: > > > > > TODO: > > > 1.change the send api in order to move it to the ndo start_xmit (unless it hurts the performance of the default driver) > > > 2.Take out the ipoib_ah from the send signature and use ib_ah instead, no need with including ipoib.h > > > 3.Check if/how to add rdma_netdev layer to the default ipoib > > > 4. splitting out the bulk rename of ipoib_priv into a single patch > > > 5. change the name of the header to be ipoib_rn.h > > > 6. no need to pass qkey, it is in the ah struct. > > > > So.. why are you resending the series? Are these going to get fixed? > > Sure, he will. This is why he added them to TODO so nothing will be lost. Well.. if I assume everything done wrong in this series is fixed, then it seems fine :) It looks like the only difference from what Intel started with was the attach/detach_mcast which is basically how I expected this to look. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
