>On 03/13/2017 04:36 PM, Guy Shattah wrote: >> >> RFC: Verbs Counters >> >> >> There is a constant demand to know about connections used in verbs (and and other aspects). >> Some vendors have been offering hardware counters for a long time by using sysfs. >> Those counters, however - are not available per connection but for the whole system. > >Are you proposing to remove the system wide counters from sysfs? > >> ibv_counter_set_description is a struct to describe other structs. >> for example, we have the following struct: >> >> >> private struct guy_counter { >> uint64_t apples_kg; >> uint64_t apples_count; >> } >> >> >> >> - note that all counters are 64bit entries > >Might be a bit wasteful for some things. Could you not have an attribute which says if its 64bit or not? > >-Denny HI, I'm not offering to remove the system-wide counters. I'm offering another way to view counters in the system. My suggestion is aimed for the developer looking to know more about Their connections, flows or other aspects which are not system-wide statistics. such counters have not been exposed so far. Regarding counters width - After giving it a lot of thought. I believe that 64bit counters are the best decision. a) Allowing more than one size of counters will make the memory allocation and data parsing harder. b) 64bit is exactly the right size. It is not too small for the terabytes of data passing in the system and it is not bit enough (like 128bit) so vendor may still choose to implement 128bit width counters as a pair of 64bit (high + low) Guy -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html