On Thu, Mar 16, 2017 at 06:51:16PM +0200, Sagi Grimberg wrote: > > > > > > > Sagi, > > > > > > The release function is placed in global workqueue. I'm not familiar > > > > > > with NVMe design and I don't know all the details, but maybe the > > > > > > proper way will > > > > > > be to create special workqueue with MEM_RECLAIM flag to ensure the > > > > > > progress? > > Leon, the release work makes progress, but it is inherently slower > than the establishment work and when we are bombarded with > establishments we have no backpressure... Sagi, How do you see that release is slower than alloc? In this specific test, all queues are empty and QP drains should finish immediately. If we rely on the prints that Yi posted in the beginning of this thread, the release function doesn't have enough priority for execution and constantly delayed. > > > I tried with 4.11.0-rc2, and still can reproduced it with less than 2000 > > times. > > Yi, > > Can you try the below (untested) patch: > > I'm not at all convinced this is the way to go because it will > slow down all the connect requests, but I'm curious to know > if it'll make the issue go away. > > -- > diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c > index ecc4fe862561..f15fa6e6b640 100644 > --- a/drivers/nvme/target/rdma.c > +++ b/drivers/nvme/target/rdma.c > @@ -1199,6 +1199,9 @@ static int nvmet_rdma_queue_connect(struct rdma_cm_id > *cm_id, > } > queue->port = cm_id->context; > > + /* Let inflight queue teardown complete */ > + flush_scheduled_work(); > + > ret = nvmet_rdma_cm_accept(cm_id, queue, &event->param.conn); > if (ret) > goto release_queue; > -- > > Any other good ideas are welcome... Maybe create separate workqueue and flush its only, instead of global system queue. It will stress the system a little bit less. Thanks > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
signature.asc
Description: PGP signature
