On Wed, Mar 15, 2017 at 08:30:43AM +0200, Leon Romanovsky wrote:
On Tue, Mar 14, 2017 at 10:11:49AM -0600, Jason Gunthorpe wrote:
On Tue, Mar 14, 2017 at 12:01:09AM -0700, Vishwanathapura, Niranjana wrote:
> On Mon, Mar 13, 2017 at 02:01:36PM -0600, Jason Gunthorpe wrote:
> >>+ /* multicast */
> >>+ int (*attach_mcast)(struct net_device *dev, struct ib_device *hca,
> >>+ union ib_gid *gid, u16 lid, int set_qkey);
> >>+ int (*detach_mcast)(struct net_device *dev, struct ib_device *hca,
> >>+ union ib_gid *gid, u16 lid);
> >
> >It would make more sense to store the struct ib_device pointer in the
> >struct rdma_netdev.
> >
>
> Agree that it shouldn't be a function parameters.
> For opa_vnic, I found it convenient to store ib_device pointer in client and
> device private structures as those will be available in most places anyhow.
If vnic uses it too, then lets add the ib_device and port num to
rdma_netdev itself?
Agree, at the end this rdma_netdev is intended for the drivers/infiniband
and it is better to have this binding (rdma_netdev and ib_device) as early as possible.
I agree with adding ibdev and port num to rdma_netdev.
Niranjana
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
