Re: [RFC v1 for accelerated IPoIB 04/25] IB/verb: Add ipoib_options struct and API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 14, 2017 at 03:25:01PM +0200, Erez Shitrit wrote:
On Mon, Mar 13, 2017 at 10:01 PM, Jason Gunthorpe
<jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote:
On Mon, Mar 13, 2017 at 08:31:15PM +0200, Erez Shitrit wrote:

diff --git a/include/rdma/ib_ipoib_accel_ops.h b/include/rdma/ib_ipoib_accel_ops.h
new file mode 100644
index 000000000000..148a5529a559
+++ b/include/rdma/ib_ipoib_accel_ops.h

Both patches need a better naming scheme for this file..

rn_opa_vnic.h
rn_ipoib.h

Maybe?

Can work for me.

vnic?


I do see why it is an issue for ipoib (we don't want two ipoib.h files). We can add rn_ prefix for vnic, but probably opa_vnic.h is good enough.

+     void *context;

What is this? Why is something other than ipoib_priv or ipoib_dev_priv
needed?

ipoib_priv is doesn't known in the lower layers, that context is used
to keep data (qp pointer in that case) that is not available
otherwise.


lower layers should be using ipoib_dev_priv() and no other context is needed. which patch is using this 'context'?

Niranjana
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux