On Tue, Mar 14, 2017 at 06:41:17PM +0200, Yishai Hadas wrote: > On 3/14/2017 5:48 PM, Jason Gunthorpe wrote: > >On Tue, Mar 14, 2017 at 01:15:42PM +0200, Yishai Hadas wrote: > >>From: Noa Osherovich <noaos@xxxxxxxxxxxx> > >> > >>Provide information about the cvlan stripping offload for > >>- ibv_create_wq > >>- ibv_modify_wq > >>- ibv_create_cq_ex > >>- ibv_query_device_ex > > > >I continue to be annoyed that these patches are extending the 'common' > >API without providing enough descriptive information to understand > >exactly what these new options are supposed to do and how to implement > >them. > > This man page patch follows other man pages spirit which basically adds the > new fields with some extra notes, there is no new verbs around and we expect > that it will be enough. > > In addition, each patch expects to be clear from usage point of view and its > purpose, it includes relevant notes in code when we found it helpful and has > a detailed commit log. > > However, if you find some specific patch that needs some extended commit log > or you can point on a specific note that needs some man page extension > please point on and we'll send an update for. As I said, it is all inadequate. If you want to extend the comon API you need to describe your extensions *somewhere* to a spec-level quality. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
