On Tue, Mar 14, 2017 at 9:01 AM, Vishwanathapura, Niranjana <niranjana.vishwanathapura@xxxxxxxxx> wrote: > On Mon, Mar 13, 2017 at 02:01:36PM -0600, Jason Gunthorpe wrote: >>> >>> + /* multicast */ >>> + int (*attach_mcast)(struct net_device *dev, struct ib_device >>> *hca, >>> + union ib_gid *gid, u16 lid, int set_qkey); >>> + int (*detach_mcast)(struct net_device *dev, struct ib_device >>> *hca, >>> + union ib_gid *gid, u16 lid); >> >> >> It would make more sense to store the struct ib_device pointer in the >> struct rdma_netdev. >> > > Agree that it shouldn't be a function parameters. > For opa_vnic, I found it convenient to store ib_device pointer in client and > device private structures as those will be available in most places anyhow. Will add it to the rdma_netdev obj, as Jason suggested. Thanks, > > Niranjana -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
