On Tue, Mar 07, 2017 at 02:44:28AM +0000, Bart Van Assche wrote: > On Tue, 2017-03-07 at 02:41 +0000, Parav Pandit wrote: > > Compilation would break when CONFIG_PCI is not defined for some embedded platforms. > > More than that, including specific pci_dev structure pointer in generic structure such as device just doesn't sound right. > > I tested equivalent patch that you sent, but I don't think this is right direction to fix this bug. > > You are welcome to voice your opinion. But unless anyone proposes a better > alternative I propose to proceed with this approach. That's not how development happens. You don't just do "here's a something I came up with, if you don't like it, tough!" If people object, you need to resolve those objections, not ignore them. Especially when you are breaking the build!!! come on now, you know better than this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html