On 02/14/2017 04:51 PM, Doug Ledford wrote:
On Sun, 2017-02-12 at 19:42 +0200, Leon Romanovsky wrote:
On Wed, Feb 08, 2017 at 05:28:01AM -0800, Dennis Dalessandro wrote:
First no need to set default to "n", it is already default.
Second, we got NAK from Doug while we proposed to add new Kconfig to
our
driver (mlx5) to improve debug.
Doug,
I would like to know if your statement do not add new Kconfigs to IB
is
still relevant.
As much as is possible, yes. Kconfig bloat is something I very much
want to avoid. I would be more willing to have a single, global
CONFIG_INFINIBAND_DEBUG option that turned on debugging stack wide than
I would for individual drivers to each have their own debug configs.
Been talking among ourselves here and for this patch and the other one
we can just rely on the standard CONFIG_FAULT_INJECTION. I will resubmit
those with my next set of patches.
In the future though it may be nice rather than having a single debug
variable, but a small set of them that are used stack wide. So no mlx or
hfi1, etc specific ones, but just for instance a general reference
counting flag for mrs and qps. If we come up with some small sane list
that we can all agree on would that be acceptable? Yeah we are growing
the kconfig but it's at least controlled and thought out.
-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
