"if (0)" is used to make this block of debug code not be executed. There is a more elegant way to let compiler ignore this code, using "#if 0 .. #endif" instead. Although it may be optimised by some compilers with specified parameter, just for readable. Signed-off-by: Minfei Huang <mnghuan@xxxxxxxxx> --- drivers/infiniband/ulp/srp/ib_srp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 36529e3..f2d7821 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -2023,12 +2023,12 @@ static void srp_recv_done(struct ib_cq *cq, struct ib_wc *wc) opcode = *(u8 *) iu->buf; - if (0) { - shost_printk(KERN_ERR, target->scsi_host, - PFX "recv completion, opcode 0x%02x\n", opcode); - print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 8, 1, - iu->buf, wc->byte_len, true); - } +#if 0 + shost_printk(KERN_ERR, target->scsi_host, + PFX "recv completion, opcode 0x%02x\n", opcode); + print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 8, 1, + iu->buf, wc->byte_len, true); +#endif switch (opcode) { case SRP_RSP: -- 2.10.1 (Apple Git-78) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html