Re: [PATCH] vmw_pvrdma: switch to pci_alloc_irq_vectors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +	ret = request_irq(pci_irq_vector(dev->pdev, 0), pvrdma_intr0_handler,
> > +			pdev->msix_enabled ? 0 : IRQF_SHARED, DRV_NAME, dev);
> > +	if (ret) {
> > +		dev_err(&dev->pdev->dev,
> > +			"failed to request interrupt 0\n");
> > +		goto out_free_vectors;
> >  	}
> >  
> > +	for (i = i; i < nr_vectors; i++) {
> 
> This should be i = 1. Looks like IRQ vector 0 was requested above.

Yeah, should be 1 and was intended as such.

> 
> > +		ret = request_irq(pci_irq_vector(dev->pdev, 0),
> 
> This should pci_irq_vector(dev->pdev, i)

Fixed.

> >  	pvrdma_free_irq(dev);
> > -	pvrdma_disable_msi_all(dev);
> > +	pci_free_irq_vectors(pdev);
> 
> There might be a conflict here. We had a fix in commit ff89b070b7c9.

I've rebased to linux-next to avoid the conflict.

I'll also fix up the free patch to use a loop - while the number of
vectors currently is fixed at three that keeps it symmetric.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux