----- Original Message ----- > From: "Bart Van Assche" <Bart.VanAssche@xxxxxxxxxxx> > To: leon@xxxxxxxxxx, loberman@xxxxxxxxxx > Cc: hch@xxxxxx, maxg@xxxxxxxxxxxx, israelr@xxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, dledford@xxxxxxxxxx > Sent: Tuesday, February 14, 2017 12:18:11 PM > Subject: Re: [PATCH 0/8] IB/srp bug fixes > > On Mon, 2017-02-13 at 22:02 -0500, Laurence Oberman wrote: > > The following 7 of 8 patches were applied to Linus's latest tree. > > > > However this required first reverting > > > > commit ad8e66b4a80182174f73487ed25fd2140cf43361 > > Author: Israel Rukshin <israelr@xxxxxxxxxxxx> > > Date: Wed Dec 28 12:48:28 2016 +0200 > > > > See my other email regarding why the above needed to be reverted. > > > > All tests passed in my mlx5 EDR-100 test bed for the ib-srp/mlx5 tests. > > > > 4.10.0-rc8.bart+ > > > > The revert of the above meant I did not apply and test patch 6 of the > > series > > IB/srp: Use the IB_DEVICE_SG_GAPS_REG HCA feature if supported > > > > IB/srp: Avoid that duplicate responses trigger a kernel bug > > IB/srp: Fix race conditions related to task management > > IB/srp: Document locking conventions > > IB/srp: Make a diagnostic message more informative > > IB/srp: Improve an error path > > *** Not applied and not tested IB/srp: Use the IB_DEVICE_SG_GAPS_REG HCA > > feature if supported > > IB/core: Add support for draining IB_POLL_DIRECT completion queues > > IB/srp: Drain the send queue before destroying a QP > > > > For the series except patch 6 > > > > Tested-by: Laurence Oberman <loberman@xxxxxxxxxx> > > Hello Laurence, > > Thank you for the testing. However, reverting commit ad8e66b4a801 without > making any further changes is not acceptable because it would reintroduce > the SG-list mapping problem addressed by that patch. Can you test the > srp-initiator-for-next branch from my github repository against mlx5 (commit > 8dca762deab6)? It passes my tests against mlx4. The patches on that branch > are: > > Bart Van Assche (8): > IB/SRP: Avoid using IB_MR_TYPE_SG_GAPS > IB/srp: Avoid that duplicate responses trigger a kernel bug > IB/srp: Fix race conditions related to task management > IB/srp: Document locking conventions > IB/srp: Make a diagnostic message more informative > IB/srp: Improve an error path > IB/core: Add support for draining IB_POLL_DIRECT completion queues > IB/srp: Drain the send queue before destroying a QP > > Thanks, > > Bart. > Western Digital Corporation (and its subsidiaries) E-mail Confidentiality > Notice & Disclaimer: > > This e-mail and any files transmitted with it may contain confidential or > legally privileged information of WDC and/or its affiliates, and are > intended solely for the use of the individual or entity to which they are > addressed. If you are not the intended recipient, any disclosure, copying, > distribution or any action taken or omitted to be taken in reliance on it, > is prohibited. If you have received this e-mail in error, please notify the > sender immediately and delete the e-mail in its entirety from your system. > > Hello Bart, Understood, will pull and test this today. Thank you for your assistance. Regards Laurence -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
