On Mon, Feb 13, 2017 at 11:52:33PM +0200, Yishai Hadas wrote: > There is nothing wrong with current usage of comp_mask, it just > follows the usage of ibv_query_rt_values_ex where it's used as both > in/out.(see below from its man page) We can update the man pages to > say it explicitly so that it will be fully clear. And I complained about that when you did it too - it is still *horrible* > That way looks quite more simple than managing an input size which may still > require a comp_mask as an output to mark which values were set in case few > fields can have a valid value of 0 but might be ignored as of legacy driver. The best is to just have unique functions or a sane multiplexor, stop copying this bad idea. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html