> -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Wednesday, February 8, 2017 6:02 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Matan Barak <matanb@xxxxxxxxxxxxxxxxxx>; Roland Dreier > <roland@xxxxxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Matan Barak > <matanb@xxxxxxxxxxxx> > Subject: Re: Need to set if_index in ib_init_ah_from_wc() ? > > On Thu, Feb 09, 2017 at 12:00:09AM +0000, Parav Pandit wrote: > > > > That still breaks link local addresses on vlan devices, so it is an > > > ugly hack, not a solution. > > > > In presence of vlan, shouldn't we be passing the ifindex of the vlan > netdev? > > yes, that is exactly my point... Oh ok. I get it. I am on right path to fix it than. Additionally, when there is macvlan based slave device present on this vlan device, I will pass the ifindex of that particular netdev. Now since we don't have MAC address coming in ib_wc nor in IB/RoCEv2 Annex spec, code needs to refer to the (a) ifaddr of the vlan netdev and (b) ifaddr of the slave netdevs Compare the DGID of the grh with ifaddr and use that netdev's ifindex for the first matching entry. Sounds reasonable now? > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
