Hi Jason, I will go through the posts. Parav > -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@xxxxxxxxxxxxxxxxxxxx] > Sent: Monday, January 30, 2017 7:50 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Roland Dreier <roland@xxxxxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; > Matan Barak <matanb@xxxxxxxxxxxx> > Subject: Re: Need to set if_index in ib_init_ah_from_wc() ? > > On Mon, Jan 30, 2017 at 05:53:40PM -0700, Jason Gunthorpe wrote: > > > In IB the matching GID table entry is placed in wc.sgid_index. > > > > I argued that rocee should do the same, but since mlx didn't implement > > this in hardware they didn't want to take the performance cost when > > building the WC. > > Sorry, I realized this reads confusingly after the fact - the argument was > about adding a wc.gid_index - IB unambigously open-codes computing > wc.gid_index .. > > I think you should review the thread starting here: > > http://www.spinics.net/lists/linux-rdma/msg30976.html > > Which is what caused this broken route lookup to be implemented in the first > place. > > And here is my first suggestion on how to fix it up: > > http://www.spinics.net/lists/linux-rdma/msg31118.html > > The fact the fundamental problems I raised during the review were not > properly addressed is what is causing these problems and confusion now. > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
