Re: [PATCH rdma-core 04/11] libbnxtre: Add support for posting and polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 28, 2017 at 05:13:35PM -0500, Devesh Sharma wrote:

> +#define true           1
> +#define false          0

Nope, delete.

> +
> +static void bnxt_re_ring_db(struct bnxt_re_dpi *dpi,
> +			    struct bnxt_re_db_hdr *hdr)
> +{
> +	uint64_t *dbval = (uint64_t *)&hdr->indx;
> +
> +	/*TODO: cpu_to_le64 */
> +	pthread_spin_lock(&dpi->db_lock);
> +	iowrite64(dpi->dbpage, dbval);
> +	/* write barrier */
> +	wmb();
> +	pthread_spin_unlock(&dpi->db_lock);

That wmb sure looks like it is in the wrong place. Better check them all..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux