> Minor suggestion. > Can you consider embedding the lock and unlock inside qed_bmap_release_id? > There are two places where this is bad idea as driver needs to release two > IDs but still one is in error flow and second is when destroying QP so for > most cases code may look a bit better. > The bitmap functions are being used by various bitmaps one of which is the cid. The cid code must allocate two consecutive cids. So here the lock is over two calls to the bit allocating call. I am planning to recode the cid to use one bit instead of two, this is further down the list. Thanks for the suggestion, Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
