On Wed, 2017-01-25 at 18:50 +0200, Leon Romanovsky wrote: > On Wed, Jan 25, 2017 at 06:41:37PM +0200, Yuval Shaia wrote: > > Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > > --- > > drivers/infiniband/core/cache.c | 18 ++++++++---------- > > drivers/infiniband/core/cma.c | 6 ++---- > > drivers/infiniband/core/device.c | 4 ++-- > > drivers/infiniband/core/verbs.c | 3 +-- > > include/rdma/ib_verbs.h | 7 +++++++ > > 5 files changed, 20 insertions(+), 18 deletions(-) > > Nice change, however all places are pretended with "!". > Can we change the name of function to something like > "rdma_is_port_invalid"? I prefer the current approach, namely with a positive function name. Bart.-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html