Re: [PATCH v3 37/37] IB/rxe, IB/rdmavt: Use dma_virt_ops instead of duplicating it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2017 at 01:04:37PM -0800, Bart Van Assche wrote:
> Make the rxe and rdmavt drivers use dma_virt_ops. Update the
> comments that refer to the source files removed by this patch.
> Remove struct ib_dma_mapping_ops. Remove ib_device.dma_ops.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
> Cc: Andrew Boyer <andrew.boyer@xxxxxxxx>
> Cc: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> Cc: Jonathan Toppins <jtoppins@xxxxxxxxxx>
> Cc: Alex Estrin <alex.estrin@xxxxxxxxx>
> Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/sw/rdmavt/Kconfig  |   1 +
>  drivers/infiniband/sw/rdmavt/Makefile |   2 +-
>  drivers/infiniband/sw/rdmavt/dma.c    | 198 ----------------------------------
>  drivers/infiniband/sw/rdmavt/dma.h    |  53 ---------
>  drivers/infiniband/sw/rdmavt/mr.c     |   8 +-
>  drivers/infiniband/sw/rdmavt/vt.c     |   4 +-
>  drivers/infiniband/sw/rdmavt/vt.h     |   1 -
>  drivers/infiniband/sw/rxe/Kconfig     |   1 +
>  drivers/infiniband/sw/rxe/Makefile    |   1 -
>  drivers/infiniband/sw/rxe/rxe_dma.c   | 183 -------------------------------
>  drivers/infiniband/sw/rxe/rxe_loc.h   |   2 -
>  drivers/infiniband/sw/rxe/rxe_verbs.c |   3 +-
>  include/rdma/ib_verbs.h               | 103 ++----------------
>  13 files changed, 18 insertions(+), 542 deletions(-)
>  delete mode 100644 drivers/infiniband/sw/rdmavt/dma.c
>  delete mode 100644 drivers/infiniband/sw/rdmavt/dma.h
>  delete mode 100644 drivers/infiniband/sw/rxe/rxe_dma.c
>
> diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
> index 1da8d01a6855..fdd001ce13d8 100644
> --- a/drivers/infiniband/sw/rdmavt/Kconfig
> +++ b/drivers/infiniband/sw/rdmavt/Kconfig
> @@ -1,5 +1,6 @@
>  config INFINIBAND_RDMAVT
>  	tristate "RDMA verbs transport library"
>  	depends on 64BIT
> +	select DMA_VIRT_OPS

Bart,
Small question, is it an easy way to select this option
for whole INFINIBAND instead of doing for every driver?

Besides that,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux