Re: [PATCHv2 1/2] IB/iser: Fix sg_tablesize calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




For devices that can register page list that is bigger than
USHRT_MAX, we actually take the wrong value for sg_tablesize.
E.g: for CX4 max_fast_reg_page_list_len is 65536 (bigger than USHRT_MAX)
so we set sg_tablesize to 0 by mistake. Therefore, each IO that is
bigger than 4k splitted to "< 4k" chunks that cause performance degredation.
Remove wrong sg_tablesize assignment, and use the value that was set during
address resolution handler with the needed casting.

Fixes: 911f4331bc87 ("IB/mlx5: Expose correct max_fast_reg_page_list_len")

That's not correct, the patch was a fix which exposed a bug in iser
that was broken anyway. Let's remove it.

Other than that, looks good,

Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux