Hi Yuval, > -----Original Message----- > From: Yuval Shaia [mailto:yuval.shaia@xxxxxxxxxx] > Sent: Monday, January 16, 2017 2:32 PM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: hch@xxxxxx; sagi@xxxxxxxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; dledford@xxxxxxxxxx > Subject: Re: [PATCHv1] nvmet-rdma: Fix missing dma sync to nvme data > structures > > On Mon, Jan 16, 2017 at 02:19:05PM -0600, Parav Pandit wrote: > > This patch performs dma sync operations on nvme_command, inline > > page(s) and nvme_completion. > > > > nvme_command and write cmd inline data is synced > > (a) on receiving of the recv queue completion for cpu access. > > (b) before posting recv wqe back to rdma adapter for device access. > > > > nvme_completion is synced > > (a) on receiving send completion for nvme_completion for cpu access. > > (b) before posting send wqe to rdma adapter for device access. > > > > This patch is generated for git://git.infradead.org/nvme-fabrics.git > > Branch: nvmf-4.10 > > > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > > Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx> > > --- > > drivers/nvme/target/rdma.c | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > > > diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c > > index 6c1c368..fe7e257 100644 > > --- a/drivers/nvme/target/rdma.c > > +++ b/drivers/nvme/target/rdma.c > > @@ -437,6 +437,14 @@ static int nvmet_rdma_post_recv(struct > nvmet_rdma_device *ndev, > > struct nvmet_rdma_cmd *cmd) > > { > > struct ib_recv_wr *bad_wr; > > + int i; > > + > > + for (i = 0; i < 2; i++) { > > + if (cmd->sge[i].length) > > + ib_dma_sync_single_for_device(ndev->device, > > Aren't we trying to get rid of all these ib_dma_* wrappers? Yes. We are. Bart patch is still not merged. Lastly there was some issue with SDMA or hfi changes. I have sent out patch on top of Bart's patch for inux-rdma tree using regular dma_xx APIs. However Sagi and Christoph acknowledged that this fix needs to go to 4.8-stable and 4.10-rc as bug fix. So this patch is generated from the nvme-fabrics tree as mentioned in comment. When this gets to linux-rdma tree, Bart's new patch will translate this additional calls to regular dma_xx APIs. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
