> -----Original Message----- > From: Christoph Hellwig [mailto:hch@xxxxxx] > Sent: Monday, January 16, 2017 9:31 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: hch@xxxxxx; sagi@xxxxxxxxxxx; linux-nvme@xxxxxxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; dledford@xxxxxxxxxx > Subject: Re: [PATCH] nvmet-rdma: Fix missing dma sync to nvme data > structures > > > +++ b/drivers/nvme/target/rdma.c > > @@ -438,6 +438,14 @@ static int nvmet_rdma_post_recv(struct > > nvmet_rdma_device *ndev, { > > struct ib_recv_wr *bad_wr; > > > > + ib_dma_sync_single_for_device(ndev->device, > > + cmd->sge[0].addr, sizeof(*cmd->nvme_cmd), > > + DMA_FROM_DEVICE); > > + > > + if (cmd->sge[1].addr) > > 0 can be a valid address returned from dma_map_single on some > architectures. I see. I will change it to check for the non-zero length instead of non-zero address. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
