Re: [PATCH V1 rdma-core] rdma: Handle uninitialized data for ibv_cmd_modify_qp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 10, 2017 at 07:24:30PM +0200, Yishai Hadas wrote:
> Instead of checking per field whether wasn't set then use explicit = 0,
> go over the providers and initialize their input command by using = {}.
>
> This comes as a pre-patch before introducing the ibv_cmd_modify_qp_ex
> which will do the same.
>
> The above drops the need to add an extra 'zeroing' code each time
> when a new field is introduced.
>
> This improves commit 77fbb25e4c2a1f99d812752f85a28978ece32fe0 as pointed
> above.
>
> Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> ---
>  libibverbs/cmd.c                 | 47 +---------------------------------------
>  providers/cxgb3/verbs.c          |  2 +-
>  providers/cxgb4/qp.c             |  2 +-
>  providers/cxgb4/verbs.c          |  2 +-
>  providers/hfi1verbs/verbs.c      |  2 +-
>  providers/hns/hns_roce_u_hw_v1.c |  2 +-
>  providers/i40iw/i40iw_uverbs.c   |  2 +-
>  providers/ipathverbs/verbs.c     |  2 +-
>  providers/mlx4/verbs.c           |  2 +-
>  providers/mlx5/verbs.c           |  2 +-
>  providers/mthca/verbs.c          |  2 +-
>  providers/nes/nes_uverbs.c       |  2 +-
>  providers/ocrdma/ocrdma_verbs.c  |  2 +-
>  providers/qedr/qelr_verbs.c      |  2 +-
>  providers/rxe/rxe.c              |  2 +-
>  15 files changed, 15 insertions(+), 60 deletions(-)
>

Thanks,
Acked-by: Leon Romanovsky <leon@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux