On 1/9/2017 5:39 PM, Jason Gunthorpe wrote:
On Sun, Jan 08, 2017 at 06:32:28PM +0200, Yishai Hadas wrote:
+ if (attr_mask & MLX5_MODIFY_QP_EX_ATTR_MASK)
+ ret = ibv_cmd_modify_qp_ex(qp, attr, attr_mask,
+ &cmd_ex,
+ sizeof(cmd_ex), sizeof(cmd_ex),
+ &resp,
+ sizeof(resp), sizeof(resp));
+ else
+ ret = ibv_cmd_modify_qp(qp, attr, attr_mask,
+ &cmd, sizeof(cmd));
What is this if doing? Is it trying to retain compat with old kernels?
Correct, only when the input mask requires the extended command it will
be used, calling the extended command always will fail in legacy kernels
as they don't support it, need to prevent that.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
