Re: [for-next 07/10] IB/mlx5: Use blue flame register allocator in mlx5_ib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
Date: Fri, 6 Jan 2017 08:06:09 +0200

> On Thu, Jan 05, 2017 at 03:07:31PM -0500, David Miller wrote:
>> From: Eli Cohen <eli@xxxxxxxxxxxxxxxxxx>
>> Date: Thu, 5 Jan 2017 14:03:18 -0600
>>
>> > If necessary I can make sure it builds on 32 bits as well.
>>
>> Please do.
> 
> Dave,
> 
> I'm failing to understand the benefits of building mlx5 on 32 bits, and
> see only disadvantages:
>  * It is actual dead code without test coverage.
>  * It misleads reviewers/customers by seeing code for 32 bits.
>  * It adds compilation time for 32 bits platforms and "punishes" them
>    for not relevant for them driver.
> 
> Why do you call removing all that as a "regression"?

We have this thing called "CONFIG_COMPILE_TEST", it has tons of value,
perhaps you've seen it before?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux