Re: [PATCH 09/15] IB/rxe: Add a runtime check in alloc_index()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 04, 2017 at 06:38:45PM +0000, Bart Van Assche wrote:
> On Wed, 2017-01-04 at 19:27 +0200, Leon Romanovsky wrote:
> > On Mon, Jan 02, 2017 at 10:41:58AM +0000, Bart Van Assche wrote:
> > > Since index values equal to or above 'range' can trigger memory
> > > corruption, complain if index >= range.
> >
> > It looks like severe bug and the proper error folding is needed, if it
> > is a real situation.
>
> Code in other functions guarantees that this condition won't be hit. The warning
> I added is intended to catch bugs if that other code would ever be modified.

It sounds reasonable.
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Thanks.

>
> Bart.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux