On Tue, Jan 03, 2017 at 10:34:32AM +0800, Yanjun Zhu wrote: > Any comment ? > > > On 2016/12/19 20:49, Zhu Yanjun wrote: > > In the function ipoib_set_dev_features, the returned value is always 0. > > As such, it is not necessary to check the returned value. > > This is not a bug. When I read the source code, I think it is not > > necessary to check it. > > > > Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx> > > --- > > drivers/infiniband/ulp/ipoib/ipoib.h | 2 +- > > drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++------ > > 2 files changed, 3 insertions(+), 7 deletions(-) ➜ linux-rdma git:(rdma-next) grep -rI ipoib_set_dev_features drivers/infiniband/ulp/ipoib/* drivers/infiniband/ulp/ipoib/ipoib.h:int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca); drivers/infiniband/ulp/ipoib/ipoib_main.c:int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca) drivers/infiniband/ulp/ipoib/ipoib_main.c: result = ipoib_set_dev_features(priv, hca); drivers/infiniband/ulp/ipoib/ipoib_vlan.c: result = ipoib_set_dev_features(priv, ppriv->ca); It lloks like, you frogot to update ipib_vlan.c
Attachment:
signature.asc
Description: PGP signature
