Re: [PATCH 0/3] IB/rxe: Three small fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/22/2016 3:23 PM, Leon Romanovsky wrote:
> On Thu, Dec 22, 2016 at 02:19:50PM -0500, Doug Ledford wrote:
>> On 12/22/2016 2:05 PM, Leon Romanovsky wrote:
>>> On Thu, Dec 22, 2016 at 01:33:43PM -0500, Doug Ledford wrote:
>>>> On 12/22/2016 12:18 PM, Leon Romanovsky wrote:
>>>>> On Thu, Dec 22, 2016 at 11:41:24AM -0500, Doug Ledford wrote:
>>>>>> On 12/22/2016 8:54 AM, Andrew Boyer wrote:
>>>>>>> This patch series addresses two issues found during heavy traffic
>>>>>>> testing as well as a recently-reported Smatch issue.
>>>>>>>
>>>>>>> Andrew Boyer (3):
>>>>>>>   IB/rxe: Use BTH_PSN_MASK when ACKing duplicate sends
>>>>>>>   IB/rxe: Drop future atomic/read packets rather than retrying
>>>>>>>   IB/rxe: Don't check for null ptr in send()
>>>>>>>
>>>>>>>  drivers/infiniband/sw/rxe/rxe_comp.c | 2 +-
>>>>>>>  drivers/infiniband/sw/rxe/rxe_net.c  | 3 +--
>>>>>>>  drivers/infiniband/sw/rxe/rxe_resp.c | 3 ++-
>>>>>>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>>>>>>
>>>>>>
>>>>>> Thanks, series applied.
>>>>>
>>>>> Hi Doug,
>>>>>
>>>>> Thank you for such fast response, but can you please give enough time to
>>>>> other reviewers/relevant maintainers to take a look on them before
>>>>> applying?
>>>>
>>>> If the patches look like they need review, I wait for review.  These did
>>>> not meet that criteria IMO.
>>>
>>> Two of three are trivial, and another one is worth to take an extra time
>>> to review.
>>
>> Which one did you think was not trivial?
> 
> Personaly for me, it was second patch from the series.

That patch was found by experience.  Even if it isn't totally correct,
it improved the specific situation.  I'm fine taking that patch and if
the maintainer of rxe thinks there is a better way, I'm open to follow
on patches.


-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux