Hi Leon, Please see inline. > -----Original Message----- > From: Leon Romanovsky [mailto:leonro@xxxxxxxxxxxx] > Sent: Thursday, December 15, 2016 1:18 PM > To: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > Cc: Nikolova, Tatyana E <tatyana.e.nikolova@xxxxxxxxx>; > dledford@xxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; e1000- > rdma@xxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH V2 08/10] i40iw: Control debug error prints using env > variable > > On Thu, Dec 15, 2016 at 11:50:34AM -0700, Jason Gunthorpe wrote: > > On Thu, Dec 15, 2016 at 08:35:37PM +0200, Leon Romanovsky wrote: > > > > > I had in mind much simplier infrastucture, just add pr_debug(..) > > > call and allow every provider to place in any place in their code. > > > > I think the bitmask thing has to be hoisted too. > > > > > My main point is that I want to see all ENV variables in one place. > > > > Why? > > There are two reasons: > 1. Easy to document and for curious users to spot all possible variables. [Tatyana Nikolova] Thank you for providing an example for the environment variables. IMO the malloc implementation brings unnecessary overhead in terms of memory and code. A text file containing all environment variables and updated every time a new environment variable is added sounds like a good idea to keep them in one place. > 2. It helps to potential authors to reuse variables instead of inventing their > own. [Tatyana Nikolova] Jason gave an example with " VERBS_PROVIDER_DEBUG=qp,ah,blah". Should all of the environment variables, enabling other features in rdma-core use a similar approach? Current environment variables are provider specific. How are they going to be reused without renaming? Renaming may create issues with applications and scripts already using the existing ones. > > > > I really don't want to see util/ files include provider headers, for > > instance, so I don't like your SET() macro idea.. > > > > At this point I'd settle for having all ENV vars *documented* in one > > place :( > > See, reason #1 :) > > > > > Jason > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
