Re: [PATCH] qede: fix general protection fault may occur on probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/23/2016 3:03 AM, Amrani, Ram wrote:
> The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot.
> 
> Signed-off-by: Ram Amrani <Ram.Amrani@xxxxxxxxxx>
> ---
> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> index 9867f96..4927271 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
>               }
>               mutex_unlock(&qedr_dev_list_lock);
> 
> -              DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
> -                             qedr_counter);
> +             pr_notice("qedr: discovered and registered %d RoCE funcs\n",
> +                              qedr_counter);
> 
>                return 0;
> }
> --
> 1.8.3.1
> 

This patch was seriously malformed (spaces instead of tabs, no space
beginning the line that ends the patch, etc).  I redid it by hand, it's
now applied.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: 0E572FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux