On Fri, Dec 02, 2016 at 03:07:27PM +0200, Yuval Shaia wrote:
> On Sun, Oct 02, 2016 at 07:10:32PM -0700, Adit Ranadive wrote:
> > + } else {
> > + qp->is_kernel = true;
> > +
> > + ret = pvrdma_set_sq_size(to_vdev(pd->device),
> > + &init_attr->cap,
> > + init_attr->qp_type, qp);
> > + if (ret)
> > + goto err_qp;
> > +
> > + ret = pvrdma_set_rq_size(to_vdev(pd->device),
> > + &init_attr->cap, qp);
> > + if (ret)
> > + goto err_qp;
> > +
> > + qp->npages = qp->npages_send + qp->npages_recv;
>
> Per next comment shouldn't it be:
> qp->npages = qp->npages_send + qp->npages_recv + PAGE_SIZE;
>
> Otherwise there will be only npages_send - 1 pages for send ring.
>
> > +
> > + /* Skip header page. */
> > + qp->sq.offset = PAGE_SIZE;
> > +
> > + /* Recv queue pages are after send pages. */
> > + qp->rq.offset = qp->npages_send * PAGE_SIZE;
>
> Unless i'm missing something here, per comment it should be:
> qp->rq.offset = qp->sq.offset + qp->npages_send * PAGE_SIZE;
Hi,
Any comments about this question?
>
> > + }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
